feat(proxy/http): recover abandoned http requests #3903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a small mechanical refactor to the http/1 client. our http/2 and "orig_proto" clients are tower services. our http/1 client, on the other hand, exposes a concrete inherent method `request`. to be consistent, this changes our http client to treat this http/1 client as a service as well. Signed-off-by: katelyn martin <[email protected]>
this commit introduces a concrete error type for the `orig_proto` upgrade layer. this layer is used by the proxy's http client to transparently upgrade outbound http/1 traffic to http/2. rather than boxing errors, we define a concrete error type to facilitate inspecting errors in the future. for now, the top-level http client continues to box errors thrown by the "orig_proto" upgrade client. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/proxy-http.concrete-type-for-downgrade-errors
branch
from
c50c590 to
7382b65
Compare
Base automatically changed from
kate/proxy-http.concrete-type-for-downgrade-errors
to
main
May 12, 2025 19:59
|
leaving a note here: i'm driving some work upstream to help us adopt there are still some open design questions about what this should look like, and on our end it will require some thought to figure out how we should dispatch recovered requests within our because this has been a draft for a while now, i'm going to close this. we can pick it back up at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 🚧 🚧